-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granular compiler tests #589
Conversation
89d9055
to
d559bc0
Compare
Nice changes, will definitely make testing more easy. I do wonder if we can't do more with these ComponentConfigs ? Now they are a bit of an afterthought and only used for testing. Maybe we can also use them to configure the components for a runner ? |
Thinking about it now, they seem to very similar to the |
Not sure yet how to use them, but if we only use them for testing, I would remove them from the core Fondant code. We can either
|
I think we are all feeling the same thing: This is really clean but we only use it for testing right now so either:
|
Thanks for the suggestions, moved them over to a separate |
Addresses https://github.com/ml6team/fondant-use-cases/issues/46
For each compiler we now have a method
get_pipeline_configs()
to fetch the essential information about a pipeline (component, arguments, dependencies, hardware, ...) from a compiled specification file. In this way, we no longer face issues with having to modify the specification files after every small modification to the framework. It also makes it easier to call the desired attribute without having to dive deep into the schema of the compiler.