Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing pre-commit building component READMEs #596

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Fixing pre-commit building component READMEs #596

merged 3 commits into from
Nov 8, 2023

Conversation

mrchtr
Copy link
Contributor

@mrchtr mrchtr commented Nov 8, 2023

The pre-commit was failing due to missing dependencies.

@RobbeSneyders
Copy link
Member

Thanks @mrchtr, I think we should add PyYAML as a core dependency of Fondant though, since we use it explicitly in fondant.core

@mrchtr
Copy link
Contributor Author

mrchtr commented Nov 8, 2023

Thanks @mrchtr, I think we should add PyYAML as a core dependency of Fondant though, since we use it explicitly in fondant.core

I've moved the pyyaml dependency. The pipeline is failing on the PR branch but it should be resolved after merging to main.

@RobbeSneyders RobbeSneyders merged commit 7241795 into main Nov 8, 2023
4 of 5 checks passed
@RobbeSneyders RobbeSneyders deleted the fixing-pre-commit branch November 8, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbeSneyders RobbeSneyders RobbeSneyders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrchtr @RobbeSneyders