Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Content Tab to document python and Console SDK #613

Merged
merged 14 commits into from
Nov 13, 2023
Merged

Conversation

PhilippeMoussalli
Copy link
Contributor

Added Content Tabs to document the CLI and python SDK

  • The values with defaults were mainly omitted from the documentation
  • The tutorials were left to only include the CLI way of working since this is the recommended approach

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PhilippeMoussalli, looks great!

docs/components/publishing_components.md Show resolved Hide resolved
docs/guides/first_pipeline.md Outdated Show resolved Hide resolved

```
fondant run local pipeline.py
```

Note: For local testing purposes, the pipeline will only download the first 10,000 images. If you want to download the full dataset, you will need to modify the component arguments in the pipeline.py file, specifically the following part:
**Note:** For local testing purposes, the pipeline will only download the first 10,000 images. If you want to download the full dataset, you will need to modify the component arguments in the pipeline.py file, specifically the following part:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you did this below :)

docs/pipeline.md Outdated Show resolved Hide resolved
docs/pipeline.md Outdated
@@ -70,33 +70,131 @@ dependencies between components to build the DAG.
Currently Fondant supports linear DAGs with single dependencies. Support for non-linear DAGs will be
available in future releases.

## Compiling and Running a pipeline
## Compiling a pipeline

Once all your components are added to your pipeline you can use different compilers to run your
pipeline:

!!! note "IMPORTANT"
When using other runners you will need to make sure that your new environment has access to:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note is broken

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still broken.

Comment on lines 55 to 56
gcp_mounr_dir = CloudCredentialsMount.GCP.value
compiler = DockerCompiler(extra_volumnes=gcp_mounr_dir)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gcp_mounr_dir = CloudCredentialsMount.GCP.value
compiler = DockerCompiler(extra_volumnes=gcp_mounr_dir)
gcp_mount_dir = CloudCredentialsMount.GCP.value
compiler = DockerCompiler(extra_volumes=gcp_mount_dir)

I also think extra_volumes needs to be a list.

Same changes in the other tabs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the script to also accept a string (single volume to mount)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that 😅

There's also some typo's in these lines though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops fixed it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more typo remaining 🙂

"extra_volumnes" -> "extra_volumes"

docs/pipeline.md Outdated Show resolved Hide resolved
src/fondant/core/schema.py Show resolved Hide resolved
PhilippeMoussalli and others added 2 commits November 10, 2023 13:58
Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
Copy link
Contributor

@mrchtr mrchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PhilippeMoussalli. Found a few small things.

docs/data_explorer.md Outdated Show resolved Hide resolved
docs/data_explorer.md Outdated Show resolved Hide resolved
fondant run local <pipeline_ref>
```

If you want to use remote paths (GCS, S3, etc.) you can use the `--auth-gcp`, `--auth-aws` or `--auth-azure`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it makes sense to split it up as well (similar to the example below).
Selecting/activate the right session/profile for different cloud providers works differently.
If we would add the commands for each cloud provider everything would be here on the page.

@RobbeSneyders RobbeSneyders merged commit f9d906a into main Nov 13, 2023
6 checks passed
@RobbeSneyders RobbeSneyders deleted the doc-add-sdk-cli branch November 13, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the docs to have a reference to both python sdk/cli
3 participants