Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand docker installation guide #619

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

PhilippeMoussalli
Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli commented Nov 13, 2023

Addresses #599
I think referencing the docker installation docs rather than pasting few snippets is better in our case since we don't require anything custom compared to airflow

@@ -58,12 +58,25 @@ Check out the [guide](../components/publishing_components.md) on publishing comp

To execute pipelines locally, you must
have [Docker compose](https://docs.docker.com/compose/install/) and Python >=3.8
installed on your system.
installed on your system. We only support Docker compose V2 and above. If you have an older version of
Docker compose, please upgrade to the latest version as described in the [Docker compose migration doc](https://docs.docker.com/compose/migrate/).

#### TODO: Modify/extend considerations for Docker-compose/desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this TODO now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@RobbeSneyders RobbeSneyders merged commit c370471 into main Nov 13, 2023
6 checks passed
@RobbeSneyders RobbeSneyders deleted the doc-docker-installation branch November 13, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert extensive guide on Docker installation
2 participants