Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #622

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Update README #622

merged 4 commits into from
Nov 14, 2023

Conversation

RobbeSneyders
Copy link
Member

This PR updates our README to reflect the latest state.

  • Update central messaging
  • Remove detailed component overview in favor of higher level overview and referral to component hub
  • Make example pipelines more visible
  • Put contributing options back into README and highlight only most useful ones
  • Remove outdated roadmap

@RobbeSneyders RobbeSneyders mentioned this pull request Nov 13, 2023
Merged
PhilippeMoussalli
PhilippeMoussalli approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Robbe! Much cleaner

README.md
[our discord](https://discord.gg/HnTdWhydGp) or submit an idea in our
[Github Discussions](https://github.com/ml6team/fondant/discussions/categories/ideas).
| | |
|----------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli Nov 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is an extra row that can be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the empty header. If we remove it, it will no longer render as a table.

mrchtr
mrchtr approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@mrchtr mrchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would focus on reusable component contributions for now. I think that one is the most accessible and useful.

Alright, makes sense. Thanks!

@RobbeSneyders RobbeSneyders merged commit 3c080ce into main Nov 14, 2023
5 of 6 checks passed
@RobbeSneyders RobbeSneyders deleted the feature/update-readme branch November 14, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeMoussalli PhilippeMoussalli PhilippeMoussalli approved these changes

@mrchtr mrchtr mrchtr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobbeSneyders @mrchtr @PhilippeMoussalli