Add architecture description and plot #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PhilippeMoussalli
commented
Nov 14, 2023
PhilippeMoussalli
commented
PhilippeMoussalli
force-pushed
the
add-architecture-page
branch
from
9dd84c5
to
ebca641
Compare
There was a problem hiding this comment.
Thanks @PhilippeMoussalli!
Can you add a link to the architecture docs in the "Contributing" part of the README?
docs/architecture.md
Outdated
|
|
||
| ### Coming soon | ||
| <p align="center"> | ||
| <img src="https://raw.githubusercontent.com/ml6team/fondant/main/docs/art/architecture.png"/> |
There was a problem hiding this comment.
We can use relative links everywhere but the README.
Done :), had to modify the plot to make the font bigger because it appeared small in the docs |
RobbeSneyders
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.