-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure data explorer #657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PhilippeMoussalli!
The UI looks nice! One of the downsides of the multi-page app seems to be that the sidebar reloads every time, which doesn't feel that smooth. Is there a way around this?
.pre-commit-config.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including this!
Maybe we can move the options from the sidebar to the front page? |
That would be one option.
|
This is how the new design looks like. I managed to save some space by including some widgets on the same row. It should be faster now. |
487b490
to
e68dc38
Compare
e68dc38
to
126d63d
Compare
|
||
def create_common_interface(self): | ||
"""Sets up the Streamlit app's main interface with common elements.""" | ||
add_logo("content/fondant_logo.png") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not added in this PR.
data_explorer/requirements.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add streamlit_extras
as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PhilippeMoussalli!
I have to admit I didn't go through the code in detail. I mostly tested the app :)
Yes I understand :) the diffs are large because of the restructuring but a lot of it is the same script with some small modifications. Next PRs should be easier to review |
PR that restructures the data explorer to have multipages for the different functionalities. This provides a cleaner interface and better development of features in isolation.
Here is a schema to showcase the architecture of the new design:
Notes: