Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign dataset format #672

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

RobbeSneyders
Copy link
Member

This is the feature branch to redesign the dataset format. All individual changes have already been reviewed.

mrchtr and others added 4 commits November 24, 2023 08:49
First PR related to the data structure redesign. 

Implements the following: 
- New manifest structure (including validation, and evolution)
- New ComponentSpec structure (including validation)
- Removes `Subsets` and `Index`

Not all tests are running successfully. But this are already quite a few
changes. Therefore, I've created PR on feature branch
`feature/redesign-dataset-format-and-interface`, to have quicker
feedback loops.

---------

Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
Co-authored-by: Philippe Moussalli <philippe.moussalli95@gmail.com>
Refactor component package as part of #643

---------

Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
Co-authored-by: Philippe Moussalli <philippe.moussalli95@gmail.com>
This PR applies the usage of the new data format:

- fixes all tests
- update component specifications and component code
- remove subset field usage in `pipeline.py`

---------

Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
#656 

We might want to validate this by checking that the field mentioned in
`previous_index` is also defined in the `consumes` section.
@RobbeSneyders RobbeSneyders merged commit be8c67b into main Nov 27, 2023
4 of 5 checks passed
@RobbeSneyders RobbeSneyders deleted the feature/redesign-dataset-format-and-interface branch November 27, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants