-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli commands for sagemaker #680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GeorgesLorre! One minor comment :)
src/fondant/cli.py
Outdated
"--output-path", | ||
"-o", | ||
help="Output path of compiled pipeline", | ||
default="sagemaker_pipeline.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't we know hiding the compiled pipeline files in a .pipeline
folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a .fondant
folder, I'll update the defaults
9391ec5
to
214b877
Compare
214b877
to
5b46f14
Compare
No description provided.