Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli commands for sagemaker #680

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Add cli commands for sagemaker #680

merged 6 commits into from
Nov 28, 2023

Conversation

GeorgesLorre
Copy link
Collaborator

No description provided.

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GeorgesLorre! One minor comment :)

src/fondant/cli.py Outdated Show resolved Hide resolved
"--output-path",
"-o",
help="Output path of compiled pipeline",
default="sagemaker_pipeline.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't we know hiding the compiled pipeline files in a .pipeline folder?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a .fondant folder, I'll update the defaults

Base automatically changed from feature/sagemaker-compile-and-run to main November 28, 2023 10:07
@RobbeSneyders RobbeSneyders merged commit 7ba372f into main Nov 28, 2023
5 of 6 checks passed
@RobbeSneyders RobbeSneyders deleted the feature/sagemaker-cli branch November 28, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants