-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explorer new dataset format #682
Conversation
Thanks @PhilippeMoussalli! Ran into some issues when testing:
|
Yes I ran into a few of those as well, I introduced new updates to fix them: - Flickering The rest of the small issues were also handled (pipeline visualization, image gallery, numerical analysis, fixed screen size). I fixed other issues as well to better navigate the datasets. Let me know if you run into any more issues |
3b45ccd
to
c1eea9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, seems to work without issues now.
One downside to the global pagination is that all the built-in filtering, sorting, etc. now only works on the 20 loaded rows. Not sure if this is an issue.
Yeah I think before it was also enabled per individual loaded partitions. The global search should partially solve this. We can decide to completely omit the build it in filtering if having two search functionalities might seem confusing |
PR that changes the explorer to match the new dataset format.
There is some weird refersh error that is occurring which might get resolved/ will be easier to debug after removing the partitions.
Let's focus on first getting this PR merged since it might fix the issue