Explorer search

[PhilippeMoussalli]

PR that adds search functionality to the explorer

other small improvements:

• Small bugfix regarding the page navigation logic
• Small changes to layout (short names, collapse sidebar information config)

[RobbeSneyders]

Thanks @PhilippeMoussalli!

Looks good. One small request. Can we make it so pressing enter in the search box executes a search?

[PhilippeMoussalli]

Thanks @PhilippeMoussalli!

Looks good. One small request. Can we make it so pressing enter in the search box executes a search?

I'v included the change. Also fixed the graphviz visualization so it looks more aligned

[RobbeSneyders]

Thanks!

Two more comments:

• Can you center the exact match / search / clear vertically?
  

• This specific order of actions leads to strange behavior:

  • Search for something which doesn't lead to any results
  • Move to a different tab
  • Move back to the dataset explorer

  --> The search value is reset, but the data explorer is still empty. You need to search again before you can clear it. This is only the case for searches that don't lead to any results.

[RobbeSneyders]

Let's remove these print statements.

[RobbeSneyders]

Let's remove these print statements.

[PhilippeMoussalli]

Thanks!

Two more comments:

• Can you center the exact match / search / clear vertically?

There is no perfect way to fix this but It should look better now, I opted for this solution. They're not perfectly aligned but better than before

• This specific order of actions leads to strange behavior:

  • Search for something which doesn't lead to any results
  • Move to a different tab
  • Move back to the dataset explorer

  --> The search value is reset, but the data explorer is still empty. You need to search again before you can clear it. This is only the case for searches that don't lead to any results.

This should be fixed now, one other strange behavior I found is that toggling the exact match on/off triggers the search even if enter is not hit. That is because streamlit refreshes on every widget event change so in this case it will detect that a text is present in the search field (even if "Enter" is not submit) and trigger the search. There is no neat way to separate the two events. I reverted back to only allowing the search via the submit button. There is an open issue to remove the "Enter to apply" placeholder to avoid confusion so we probably should do this at some point but it's not there yet.

streamlit/streamlit#7538

[RobbeSneyders]

Ok, LGTM.

Only the images on the docs are broken.

[RobbeSneyders]

Suggested change

	
	

[RobbeSneyders]

Suggested change

	
	

[PhilippeMoussalli]

woops forgot to commit them. Added them, I think the existing references are valid

[RobbeSneyders]

Thanks @PhilippeMoussalli!