Explorer improve filtering of available runs #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeMoussalli
force-pushed
the
bugfix-explorer-no-manifests
branch
from
ef2442c
to
70f55ca
Compare
data_explorer/app/main.py
Outdated
| @@ -39,9 +39,6 @@ def get_ordered_manifests_paths(run_path: str) -> t.List[str]: | |||
| for component in run_components | |||
| ] | |||
|
|
|||
| # Filter for non existing manifests (e.g. if the component failed) | |||
| manifest_paths = [path for path in manifest_paths if os.path.exists(path)] | |||
There was a problem hiding this comment.
I think we still need this. This PR fixed the issue for runs without any manifest. But if you have manifests and one component without a manifest (because it failed or was interrupted), it throws an error.
There was a problem hiding this comment.
Good catch, indeed I think that's needed. Readded it
RobbeSneyders
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix to only show runs that have existing manifests in them in the explorer.