Support pipeline factory functions as CLI reference #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
requested review from
GeorgesLorre,
PhilippeMoussalli and
Hakimovich99
TIL |
|
I'm going to review this tomorrow after a nights sleep 😉 |
GeorgesLorre
reviewed
Dec 5, 2023
| # Attribute is not a valid python name | ||
| "examples.example_modules.pipeline:pipe;line", | ||
| # Not a Pipeline | ||
| "examples.example_modules.pipeline:number", | ||
| ], | ||
| ) | ||
| def test_pipeline_from_module_error(module_str): | ||
| """Test different error cases for pipeline_from_string.""" | ||
| with pytest.raises(PipelineImportError): |
There was a problem hiding this comment.
can't you match the error messages here ? with pytest match
There was a problem hiding this comment.
Should be possible, but I didn't think it was worth the effort. Prioritizing some other work at the moment :)
There was a problem hiding this comment.
ok to merge this then if it blocking
GeorgesLorre
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our RAG use case, we want to start using a pipeline factory function, but this is currently not supported by the CLI.
This PR fixes that.
I also included a change (the first commit) which removes the
finallyblocks. We were using this as follows:But apparently the
finallyblock is also entered if any non-SpecificErrorexception is raised in thetryblock. This lead to all non-handled errors to become anUnboundLocalerror. This is now no longer the case, and the original error is not caught.