Update sagemaker docs #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgesLorre
commented
Dec 6, 2023
GeorgesLorre
commented
Dec 6, 2023
|
The sagemaker page is currently not part of the index @GeorgesLorre, can you add it? |
|
Can you also remove the "Coming Soon" from the README? |
|
Can you also add the sagemaker runner to |
|
I also see that for the other runners we are documenting the |
GeorgesLorre
force-pushed
the
feature/sagemaker-docs
branch
from
02e7ec2
to
3495f75
Compare
docs/runners/sagemaker.md
Outdated
|
|
||
| #### Assigning custom resources to the pipeline | ||
|
|
||
| You can specify different kinds of `instance_type` while running your pipeline, you can see the available options [here](https://docs.aws.amazon.com/sagemaker/latest/dg/notebooks-available-instance-types.html). You may need to request a [quota increase](https://docs.aws.amazon.com/general/latest/gr/aws_service_limits.html) for certain `instance_type`'s. |
There was a problem hiding this comment.
Does this need to be done with the CLI, or do we support a Resources instance for Sagemaker as well?
There was a problem hiding this comment.
I added it: #710
GeorgesLorre
force-pushed
the
feature/sagemaker-docs
branch
from
3495f75
to
fdcd768
Compare
RobbeSneyders
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.