Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load_from_csv component #713

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Add load_from_csv component #713

merged 6 commits into from
Dec 11, 2023

Conversation

Hakimovich99
Copy link
Contributor

No description provided.

Copy link
Contributor

@mrchtr mrchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hakimovich99! Looks already good. Left a few comments.
Additionally, I think it would be great if you could still add a simple component test.

components/load_from_csv/src/main.py Show resolved Hide resolved
components/load_from_csv/src/main.py Outdated Show resolved Hide resolved
components/load_from_csv/fondant_component.yaml Outdated Show resolved Hide resolved
@RobbeSneyders RobbeSneyders changed the title Feature/load from csv Add load_from_csv component Dec 11, 2023
@RobbeSneyders RobbeSneyders changed the base branch from main to feature/reactivate-readme-precommit December 11, 2023 19:17
Copy link
Contributor

@mrchtr mrchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Base automatically changed from feature/reactivate-readme-precommit to main December 11, 2023 22:23
@RobbeSneyders RobbeSneyders merged commit f805a25 into main Dec 11, 2023
6 checks passed
@RobbeSneyders RobbeSneyders deleted the feature/load_from_csv branch December 11, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants