Move Dask Client configuration to Component class and use multi-GPU in embed_images component
#852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No explicit tests ? Do we need to update the docs ? |
Do you have a proposal for a useful test scenario?
I'll add something indeed. |
mrchtr
reviewed
Feb 15, 2024
There was a problem hiding this comment.
I think we should set the LocalCluster for as default for all components and let the user overwrite the client if needed.
The other components still not using the LocalCluster, but it is the recommended way. Is there any reason why we shouldn't set the LocalCluster as default for the other components?
|
@mrchtr with this change we are setting the |
Ah my bad, nvm |
RobbeSneyders
force-pushed
the
feature/dask-client
branch
from
ee00432
to
41adcbb
Compare
RobbeSneyders
added a commit
that referenced
this pull request
Feb 20, 2024
This PR changes the `dask_client` method introduced in #852 into a general `setup` method. This method differs from `__init__` in that it allows users to return a state, which is passed into the `teardown` method by Fondant. This is necessary since the Dask client is not pickleable, and setting it as an instance attribute leads to issues when executing the `transform` method across processes (as is the case in the `PandasTransformComponent`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't really make sense to let the user configure the Dask client used by a component, since this is specific to the component implementation. I therefore moved it to the Component class with a default implementation of the Dask
LocalCluster. Note that due to a bug theLocalClusterwas not yet used as default. This therefore changes the default for all components, which were using the threaded scheduler before.One downside to the current implementation is that we require the component developer to call
super().__init__()in their__init__method. This is best practice though and highlighted by IDEs.