Infer consume operation if not present in dataset interface #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrchtr
commented
Feb 16, 2024
GeorgesLorre
approved these changes
Feb 19, 2024
| @property | ||
| def consumes_additional_properties(self) -> bool: | ||
| """Returns a boolean indicating whether the component consumes additional properties.""" | ||
| return self._specification.get("consumes", {}).get( |
There was a problem hiding this comment.
This might be nice to implement on the spec (same for the produces)
There was a problem hiding this comment.
Do you mean in the OperationSpec?
There was a problem hiding this comment.
I took a better look and never mind. I was lost in the many specs 😛 .
RobbeSneyders
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Thanks @mrchtr!
Left some comments, but they're mostly nits. Looks a lot cleaner now!
| logger.info(msg) | ||
| return None | ||
|
|
||
| # Component has consumes and additionalProperties, we will load all dataset columns |
There was a problem hiding this comment.
Wondering about the case here where there's both a schema and additionalProperties. But I guess this is fine for now. We might want to have more logic here once we add support for additionalProperties schemas instead of just the boolean.
GeorgesLorre
approved these changes
Feb 20, 2024
RobbeSneyders
deleted the
feature/passing-all-columns-to-the-write-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation, I still have to add tests. I wanted to get some feedback first.
ComponentSpecbased on the attributes.ComponentSpec.In cases where a user hasn't specified a
consumein the pipeline operations, we now infer this. If a component spec contains aconsumessection andadditionalPropertiesare set to true, we load all columns. IfadditionalPropertiesis set to false, we limit the columns defined in the component spec.Fix #836