Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount absolute path of working dir to local runner #931

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Mount absolute path of working dir to local runner #931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6881162
Reduce path to working dir
mrchtr Apr 9, 2024
1cc536d
Revert "Reduce path to working dir"
mrchtr Apr 12, 2024
f96d3f1
Fix local runner, mount absolute path to container
mrchtr Apr 12, 2024
0d49cec
Fix test case
mrchtr Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/fondant/dataset/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,10 @@ def resolve_local_base_path(base_path: Path) -> Path:
volume = DockerVolume(
type="bind",
source=str(p_base_path),
target=f"/{p_base_path.stem}",
target=str(p_base_path),
)
path = f"/{p_base_path.stem}"
return path, volume

return str(p_base_path), volume

def _generate_spec(
self,
Expand Down Expand Up @@ -246,7 +246,7 @@ def _generate_spec(
command.extend(
[
"--working_directory",
working_directory,
path,
],
)

Expand Down
5 changes: 2 additions & 3 deletions tests/pipeline/test_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ def test_docker_local_path(setup_pipeline, tmp_path_factory):
with tmp_path_factory.mktemp("temp") as fn:
# this is the directory mounted in the container
_, _, dataset, cache_dict = setup_pipeline
work_dir_stem = f"/{fn.stem}"
working_directory = str(fn)
compiler = DockerCompiler()
output_path = str(fn / "docker-compose.yml")
Expand All @@ -234,14 +233,14 @@ def test_docker_local_path(setup_pipeline, tmp_path_factory):
assert component_configs.volumes == [
{
"source": str(fn),
"target": work_dir_stem,
"target": str(fn),
"type": "bind",
},
]
cleaned_pipeline_name = dataset.name.replace("_", "")
# check if commands are patched to use the working dir
expected_output_manifest_path = (
f"{work_dir_stem}/{cleaned_pipeline_name}/{expected_run_id}"
f"{str(fn)}/{cleaned_pipeline_name}/{expected_run_id}"
f"/{component_name}/manifest.json"
)

Expand Down
Loading