Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Fondant base image build #936

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Bugfix: Fondant base image build #936

merged 1 commit into from
Apr 22, 2024

Conversation

mrchtr
Copy link
Contributor

@mrchtr mrchtr commented Apr 22, 2024

In 0.12.0 the lightweight component that uses a default image are not working.

  • During the build of base images the image tag list wasn't initialised correctly within the loop. This means we have overwritten the previous build images. Every base image now contains python version 10.11.9
  • We have limited dask to<2024.3.0, but only dask >=2024.4.1 is compatible with python >=10.11.9. Limit python version of the base image build.

GeorgesLorre
GeorgesLorre approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@GeorgesLorre GeorgesLorre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

@mrchtr mrchtr merged commit 2129f0c into main Apr 22, 2024
9 checks passed
@mrchtr mrchtr deleted the bugfix/fondant-base-image branch April 22, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgesLorre GeorgesLorre GeorgesLorre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrchtr @GeorgesLorre