Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Directory Support #22

Closed
emoon opened this issue Aug 17, 2016 · 9 comments
Closed

Select Directory Support #22

emoon opened this issue Aug 17, 2016 · 9 comments

Comments

@emoon
Copy link

emoon commented Aug 17, 2016

Hi,

I wonder if there are any plans on supporting the ability to select a directory?

@mlabbe
Copy link
Owner

mlabbe commented Aug 17, 2016

Hey,

Only reason it's not in there right now is because I didn't need it at the time I wrote the library. I would accept an all-os pull request targeting the devel branch that adds NFD_PickFolder(). If you are entertaining this idea, I have added a small doc on submitting pull requests hree: https://github.com/mlabbe/nativefiledialog/blob/master/docs/submitting_pull_requests.md

Alternatively, I could add it under a support agreement (programming for hire is what I do for a living).

@emoon
Copy link
Author

emoon commented Aug 20, 2016

Alright. Thanks!

@mlabbe mlabbe closed this as completed Aug 20, 2016
@MrSapps
Copy link
Contributor

MrSapps commented Aug 21, 2016

Any progress on this? I'm tempted to give it ago.

@emoon
Copy link
Author

emoon commented Aug 21, 2016

@paulsapps I have been been busy with other things so please go ahead :)

@MrSapps
Copy link
Contributor

MrSapps commented Aug 21, 2016

WIP here: https://github.com/paulsapps/nativefiledialog/tree/directory_support

win32 added, mac and linux todo

@mlabbe
Copy link
Owner

mlabbe commented Aug 21, 2016

Great! I'll reopen the issue. :)

@mlabbe mlabbe reopened this Aug 21, 2016
MrSapps added a commit to MrSapps/nativefiledialog that referenced this issue Aug 21, 2016
MrSapps added a commit to MrSapps/nativefiledialog that referenced this issue Aug 21, 2016
mlabbe added a commit that referenced this issue Aug 24, 2016
mlabbe added a commit that referenced this issue Aug 24, 2016
@mlabbe
Copy link
Owner

mlabbe commented Aug 25, 2016

This is now checked in to the devel branch and, as of e2c28bb, it's autobuilding on all platforms!

@emoon
Copy link
Author

emoon commented Aug 25, 2016

Sweet!

@mlabbe
Copy link
Owner

mlabbe commented Sep 27, 2016

I forgot to mention: this was recently pushed to master. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants