Fix compilation on older Visual Studio C++ copies #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"atlbase.h" is not included in older Visual Studio C++ Express versions, after removing it, things appear to work fine, both with new and old versions of Visual Studio Express, so it doesn't appear to be needed. Thanks! 😄
|
Which versions did you test? |
|
Oh! Sorry I didn't see your comment. I believe we've tested as far back as Express 2008, and as new as the 2015 community editions 😄 |
|
Works fine without atlbase.h. This PR is necessary to merge. |
|
Thanks, I finally got around to testing this on a handful of compilers and versions. |
MrSapps
added a commit
to MrSapps/nativefiledialog
that referenced
this pull request
Aug 21, 2016
Add win32 impl of NFD_PickFolder stub osx/gtk impl, add own impl of ComPtr since VS2010 is antique fix build errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"atlbase.h" is not included in older Visual Studio C++ Express versions, after removing it, things appear to work fine, both with new and old versions of Visual Studio Express, so it doesn't appear to be needed. Thanks! 😄