Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zenity dialog implementation #29

Closed
wants to merge 1 commit into from
Closed

Conversation

mgerhardy
Copy link

again no premake integration - but i've read in the readme that you would like to have something like this...

@mgerhardy
Copy link
Author

could be extended to also support kdialog - but I don't have a kde env to test with.

@mgerhardy
Copy link
Author

ups - forgot to implement --file-filter support - will leave that for someone else ;)

@onqtam
Copy link

onqtam commented Aug 17, 2017

will this get merged?

@mgerhardy
Copy link
Author

premake and --file-filter support is still missing. Feel free ... ;)

@mlabbe
Copy link
Owner

mlabbe commented Aug 19, 2017

Indeed, while a Zenity implementation is desirable, it must be fully featured and easy to build. This lib has hundreds of users and I want to make sure they don't fall into the trap of opting for a backend that doesn't meet the features described in the readme.

This PR needs work before it can be merged. In addition to premake and --file-filter support, please see:
https://github.com/mlabbe/nativefiledialog/blob/master/docs/submitting_pull_requests.md

@mlabbe
Copy link
Owner

mlabbe commented Nov 12, 2017

An alternative Zenity impl was merged to devel today which builds with Premake. Took a look to see if it suits your needs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants