Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to free #33

Closed
wants to merge 1 commit into from
Closed

Added ability to free #33

wants to merge 1 commit into from

Conversation

JoNil
Copy link

@JoNil JoNil commented Jul 31, 2017

Adds a free function so you can use nfd from a dll on windows that uses a different version of msvcrt and thus a diffrent heap than your main application.

Cheers and awesome library! :)

@mlabbe
Copy link
Owner

mlabbe commented Aug 2, 2017

I'm aware of the static library limitation of NFD; thanks for taking a step in the right direction. Did you manage to update the Premake scripts to optionally generate DLLs? It seems that this PR makes sense in the context of a build feature that doesn't yet exist.

I'd happily take a build script PR that adds DLL support.

@mlabbe
Copy link
Owner

mlabbe commented Nov 24, 2017

Hey, I'm wondering if you want to weigh in here on my question. I'm going to release the next version of NFD in a couple weeks; we've had some updates I'll be moving from the devel branch to master. If not, no worries.

@mlabbe
Copy link
Owner

mlabbe commented Dec 30, 2018

PR is good but not comprehensive; a larger update to address the shared library is planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants