fix(menu): Added fixes required for Concurrent Rendering

mlaursen · Nov 27, 2021 · 05ec620 · 05ec620
1 parent 75663e4
commit 05ec620
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/packages/menu/src/Menu.tsx b/packages/menu/src/Menu.tsx
@@ -210,12 +210,14 @@ export const Menu = forwardRef<HTMLDivElement, MenuProps>(function Menu(
 
   const [cancelled, setCancelled] = useState(false);
   const prevVisible = useRef(visible);
-  if (prevVisible.current !== visible) {
-    prevVisible.current = visible;
-    if (cancelled) {
-      setCancelled(false);
+  useEffect(() => {
+    if (prevVisible.current !== visible) {
+      prevVisible.current = visible;
+      if (cancelled) {
+        setCancelled(false);
+      }
     }
-  }
+  }, [visible, cancelled]);
 
   const fixedTo = useRef<HTMLElement | null>(null);
   useEffect(() => {