[Fix] Support fetching images when using worker engine #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation relied on the HTMLImageElement constuctor which is not available in worker contexts.
|
Really appreciate the fix, will take a look soon! Meanwhile if convenient, could you provide a small example that wouldn't work with the previous implementation but will work now? Or would feeding image to |
|
Using the worker engine in examples/vision-model shows the issue: dstoc@d019388 Let me know if you want to add that change into this PR. |
|
I see!
That'd be great. Perhaps with a |
CharlieFRuan
approved these changes
Sep 26, 2024
|
Added. |
|
Great work, thank you! |
|
Ahh I think the |
CharlieFRuan
added a commit
that referenced
this pull request
Sep 26, 2024
### Change - #574 - Enable image input for web/service worker ### TVMjs - No change, version `0.18.0-dev0` just like 0.2.66 - Built at apache/tvm@30fb16a
jzhao62
pushed a commit
to jzhao62/web-llm
that referenced
this pull request
Dec 8, 2024
The previous implementation relied on the HTMLImageElement constuctor which is not available in worker contexts.
jzhao62
pushed a commit
to jzhao62/web-llm
that referenced
this pull request
Dec 8, 2024
### Change - mlc-ai#574 - Enable image input for web/service worker ### TVMjs - No change, version `0.18.0-dev0` just like 0.2.66 - Built at apache/tvm@30fb16a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation relied on the HTMLImageElement constuctor which is not available in worker contexts.