Use CUDA_VISIBLE_DEVICES by default #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
benoit-cty
commented
Nov 18, 2024
benoit-cty
commented
Nov 18, 2024
benoit-cty
commented
Nov 18, 2024
added 16 commits
November 18, 2024 20:55
benoit-cty
force-pushed
the
689-use-cuda_visible_devices-by-default
branch
from
8dd14d6 to
dc72396
Compare
inimaz
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Thanks for this @benoit-cty !
Just small typo in one of the checks.
SaboniAmine
reviewed
Nov 19, 2024
Co-authored-by: inimaz <49730431+inimaz@users.noreply.github.com>
inimaz
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #567 it will be better for CodeCarbon to use the env variable CUDA_VISIBLE_DEVICES as a default value for the parameter gpu_ids.
I also drop Python 3.8 from CI as it is deprecated https://devguide.python.org/versions/ and use the same Python version everywhere in CI for consistency. I kept 3.8 in supported version to allow our users to continue to use CodeCarbon in 3.8 until it stop working.