-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass train_state
to update_params
#790
Merged
priyakasimbeg
merged 10 commits into
mlcommons:dev
from
Niccolo-Ajroldi:pass_train_state
Oct 29, 2024
Merged
Pass train_state
to update_params
#790
priyakasimbeg
merged 10 commits into
mlcommons:dev
from
Niccolo-Ajroldi:pass_train_state
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(shallow) copy in submission_runner
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
priyakasimbeg
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request adds
train_state
to the arguments ofupdate_params
.This allows for example to implement a time-based LR scheduler (see #785).
Since
train_state
is a dictionary, we have to avoid that a submission modifies its content.The solution adopted here passes
train_state
by copy. We use a shallow copying, since all values intrain_state
are primitive types, and cannot be modified in-place. Although very fast, this copying operation would however be counted as part of the submission time.A possible alternative solution that would avoid this problem would be to pass
train_state['accumulated_submission_time']
directly instead of passing the entire dictionary.