keep original data_deps while resolving graph #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/feeder/et_feeder_node.cpp modified: src/feeder/et_feeder_node.h
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
JoongunPark
reviewed
Aug 31, 2024
There was a problem hiding this comment.
Thank you for you PR @changhai0109.
I agree with you that ASTRA-Sim needs this update.
Please check my comments!
|
Hi @changhai0109, May I request, you to ensure that the code passes all checks (File formatting, tests, etc.)? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target Issue #148
Summary
One of the future works on astrasim about memory requires getting the original data dependency from the workload. However, in the current implementation of ETFeeder the original data_deps will be mutated for recording dependency resolving. Here we introduce a duplication of data_deps called
unresolved_data_depswhich is specifically used for dependency resolving. This way we can keep original data_deps during resolving for purples of memory analysis.Test Plan
Test it with AstraSIM
run/example