fixes is_cpu_op conversion in constructor #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
is_cpu_op()
method which was always returningfalse
, due to awrong conversion
in the constructor.is_cpu_op()
method is returningbool
, but variableis_cpu_op_
was of typeuint32_t
--> changed it tobool
ETFeederNode
was being done inuint32_t
instead ofbool
--> changed it tobool
is_cpu_op
attribute is abool
Test Plan
I've tested using
2 different traces
, converted them tojson
usingchakra_jsonizer
and checked if thevalue returned by is_cpu_op()
method for a specific node isthe same with the one from the json
.