Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Redux Toolkit #270

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Feature - Redux Toolkit #270

wants to merge 11 commits into from

Conversation

shincap8
Copy link
Contributor

@shincap8 shincap8 commented Jun 5, 2024

Implement Redux Toolkit and Persist

Changes Made

  1. Install Redux-toolkit and persist.
  • Create the store to manage Redux slices and persist them to prevent managing different sources (context, state and local storage).
  1. Create Alerts for every case.
  • Alert for every case, when the concept or the category hasn't been selected, when the image hasn't been upload or when the user prompt isn't at least 20 characters longs.
  1. Prevent Image to take more space
  • Restraint the image and implement Magnifier box in order to zoom the image if needed

@shincap8 shincap8 requested a review from a team as a code owner June 5, 2024 19:21
Copy link

github-actions bot commented Jun 5, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether instead of a double dropdown we should have a Dropdown method that can be stacked or something. Is that feasible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course is feasible. We can have it that way

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you prefer? I just think having double dropdown makes it less flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants