Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Fixed Dropdown #299

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix - Fixed Dropdown #299

merged 2 commits into from
Sep 3, 2024

Conversation

shincap8
Copy link
Contributor

Context

  • Common Crawl's challenge required the dropdown to be fixed to top when scrolling the text.

Changes Made

  1. Make the dropdown be fixed to the top when the user scrolls down the page.
  • This would allow the user to easily change to another language without scrolling to the top to find the dropdown element.
  1. Fix the height of the dropdown menu so user can easily scroll through the items.
  • This would allow the user to only scroll to the menu and not also the page.
  1. Fix the input to search value to the top.
  • This would prevent the user to loose the input when scrolling down the menu.
image image

@shincap8 shincap8 requested a review from a team as a code owner August 29, 2024 23:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@shincap8 shincap8 merged commit ef25b4c into main Sep 3, 2024
13 checks passed
@shincap8 shincap8 deleted the Fix/fixed_dropdown branch September 3, 2024 12:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@remg1997 remg1997 remg1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shincap8 @remg1997