Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/enhance multigenerator #300

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Fix/enhance multigenerator #300

merged 4 commits into from
Sep 3, 2024

Conversation

shincap8
Copy link
Contributor

@shincap8 shincap8 commented Sep 3, 2024

Context

  • Avoid sending a user back to the queue

Changes Made

  1. Create the amount of workers missing to complete 5 images.
  • This would decrease the chances of a user to be sent to the tail of the queue when he/she was already at the beginning of it.
  1. Add 2 seconds to the timeout of the SDXLImageProvider.
  • This would decrease the amount of models of this kind throwing timeout error.

@shincap8 shincap8 requested a review from a team as a code owner September 3, 2024 19:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@remg1997 remg1997 merged commit bf2cfdf into main Sep 3, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
@shincap8 shincap8 deleted the Fix/enhance_multigenerator branch September 3, 2024 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@remg1997 remg1997 remg1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shincap8 @remg1997