Rename network card field following the rule #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
@pgmpablo157321 @mrasquinha-g Please approve this minor fix and merge. |
arjunsuresh
approved these changes
Jul 21, 2023
|
@pgmpablo157321 can you please merge this change asap, otherwise submission checker will be failing when the submissions are open coming Monday? |
pgmpablo157321
force-pushed
the
nvyihengz-fix-network-card-field-name
branch
from
c9486aa
to
faaa3d9
Compare
|
Tests will fail for this PR due to submission checker fail, but that's okay. |
|
DO NOT MERGE for 3.1. The change will be applied to all submissions after submission. This change to the submission checker will apply to 4.0 |
|
@pgmpablo157321 Can you please merge this PR? If you let me know when, then I can give the PR updating the submitted results. |
pgmpablo157321
approved these changes
Sep 4, 2023
|
Already discussed in a previous WG meeting, so it is ok to merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the rule:https://github.com/mlcommons/policies/blob/master/submission_rules.adoc#system_desc_id-json-metadata
the field of network card should be named as
host_network_card_count