Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix power efficiency output in submission checker #1495

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

arjunsuresh
Copy link
Contributor

No description provided.

@arjunsuresh arjunsuresh requested a review from a team as a code owner September 19, 2023 13:04
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sahelib25
Copy link
Contributor

Hi @arjunsuresh, thanks! the new update works fine for the Offline scenario, inferred from SingleStream. However, MultiStream inferred from SingleStream seems to be broken now.

closed/Krai/results/<sut1>/resnet50/multistream/performance/ranging caused exception in check_ranging_dir: name 'uses_early_stopping' is not defined

It seems the same block of code is used in two different parts of the program, https://github.com/GATEOverflow/inference/blob/0611429ef1dd1599c5eefea2c8eaeee4c24f19ac/tools/submission/submission_checker.py#L1653 and https://github.com/GATEOverflow/inference/blob/0611429ef1dd1599c5eefea2c8eaeee4c24f19ac/tools/submission/submission_checker.py#L1889

@arjunsuresh
Copy link
Contributor Author

Thank you @sahelib25 for checking it. My bad - multistream issue should be fixed now. Also shows that we need a github action for checking submission checker changes 🙂

The code was duplicated to get power metric during the ranging mode run which was originally there only during the testing mode run. Now I have separated this to a function specific to inferring results.

@sahelib25
Copy link
Contributor

Thank you @arjunsuresh for fixing the issue.

@pgmpablo157321 pgmpablo157321 merged commit 2ab860d into mlcommons:master Sep 26, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants