-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Postmortem 4.1] Make mlperf.conf static in loadgen, enable automatic Pypi release #1882
Merged
mrmhodak
merged 59 commits into
mlcommons:master
from
GATEOverflow:improve_result_generation
Oct 22, 2024
Merged
[Postmortem 4.1] Make mlperf.conf static in loadgen, enable automatic Pypi release #1882
mrmhodak
merged 59 commits into
mlcommons:master
from
GATEOverflow:improve_result_generation
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
force-pushed
the
improve_result_generation
branch
from
October 21, 2024 15:36
824ece0
to
6995f90
Compare
Added VERSION file
arjunsuresh
force-pushed
the
improve_result_generation
branch
from
October 21, 2024 15:45
7a6e748
to
c7e5fd8
Compare
arjunsuresh
changed the title
[Postmortem 4.1] Make mlperf.conf static in loadgen
[Postmortem 4.1] Make mlperf.conf static in loadgen, fix Pypi release
Oct 22, 2024
arjunsuresh
changed the title
[Postmortem 4.1] Make mlperf.conf static in loadgen, fix Pypi release
[Postmortem 4.1] Make mlperf.conf static in loadgen, enable automatic Pypi release
Oct 22, 2024
mrmhodak
approved these changes
Oct 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the below changes:
Make loadgen automatically load the
mlperf.conf
file.mlperf.conf
file is now distributed along with the loadgen source and is moved to the loadgen folder. There is a soft link at the repo root so that old workflows won't break. For this aMANIFEST.in
file is added.--mlperf_conf
option.user.conf
file.Fix compilation warnings in loadgen
-Wunused-parameter
are fixed.Enabled Automatic pypi upload for loadgen wheels
pip install mlcommons_loadgen
can now be used to install loadgen on Linux, macOS and WindowsVERSION.txt
file is added for loadgen for version info with an option for patch versionVERSION.txt
file is automatically updated (only the patch version being updated) and new wheels released whenever there is a change inside theloadgen
directory.Action item for the submitters
mlperf_log_detail
will have an error and the submission checker will fail.pip install mlcommons_loadgen
can be used