Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GBS 6144 RCPs for GPT3 benchmark #374

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Add GBS 6144 RCPs for GPT3 benchmark #374

merged 4 commits into from
Aug 1, 2024

Conversation

ShriyaPalsamudram
Copy link
Contributor

Add GBS 6144 RCP for GPT3 benchmark generated using megatron-lm

Pending: Google to update paxml generated RCP samples for the same GBS

@ShriyaPalsamudram ShriyaPalsamudram requested review from a team as code owners June 13, 2024 20:05
@ShriyaPalsamudram ShriyaPalsamudram marked this pull request as draft June 13, 2024 20:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@ZhiyuLi-goog
Copy link

Hi, @ShriyaPalsamudram,

I conducted 3 paxml runs of GBS 6144 RCP for the GPT-3 benchmark and obtained the 1409286144 num_epochs. Could you update the RCP file accordingly?

    "gpt3_ref_6144":
  {
    "Benchmark": "gpt3",
    "Creator": "Google & NVIDIA",
    "When": "Prior to 3.0 submission",
    "Platform": "TPU-v4-2048 / PaxML, 1024 H100-80GB / Megatron-LM",
    "BS": 6144,
    "Hyperparams": {
      "opt_base_learning_rate": 3e-5
    },
    "Epochs to converge": [
       1409286144, 1409286144, 1409286144, 1409286144, 1409286144, 1409286144
    ]
  },

@ShriyaPalsamudram ShriyaPalsamudram marked this pull request as ready for review July 29, 2024 14:18
@ShriyaPalsamudram
Copy link
Contributor Author

@ZhiyuLi-goog thank you for collecting the data, I have updated the PR and marked it ready for review.
Please approve so it can be merged.

ZhiyuLi-goog
ZhiyuLi-goog approved these changes Jul 29, 2024
View reviewed changes
Copy link

@ZhiyuLi-goog ZhiyuLi-goog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Shriya. LGTM.

hiwotadese
hiwotadese approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@hiwotadese hiwotadese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hiwotadese hiwotadese merged commit 369260b into mlcommons:master Aug 1, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiwotadese hiwotadese hiwotadese approved these changes

@ZhiyuLi-goog ZhiyuLi-goog ZhiyuLi-goog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShriyaPalsamudram @ZhiyuLi-goog @hiwotadese