Correct usage of build_args for singularity runner. #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing implementation in some corner cases overrides singularity runner parameters when it should not be doing so. One corner case is the following:
Using docker configuration to build the singularity image file. In this case, the `build_args` parameter is automatically set to `--fakeroot`
whenever it is detected the singularity runtime supports this. This is differet from case when there is singularity section in MLCube configuration
file in which case the `build_args` is correctly read from system settings file (default location is `${HOME}/mlcube.yaml`) or from MLCubec configuration
file.
This fix changes this behavior. The singularity runner will log the warning message whenever it does not override the build_args as it would do previously.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing implementation in some corner cases overrides singularity runner parameters when it should not be doing so. One corner case is the following:
Using docker configuration to build the singularity image file. In this case, the
build_argsparameter is automatically set to--fakerootwhenever it is detected the singularity runtime supports this. This is different from case when there is singularity section in MLCube configuration file in which case thebuild_argsis correctly read from system settings file (default location is${HOME}/mlcube.yaml) or from MLCube configuration file.This fix changes this behavior. The singularity runner will log the warning message whenever it does not override the
build_argsas it would do previously.