Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev build command for local development #134

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Add dev build command for local development #134

merged 1 commit into from
Mar 1, 2024

Conversation

mkly
Copy link
Member

@mkly mkly commented Feb 29, 2024

  • Add dev build command for local development

This is to allow for a more rapid iteration loop than running a full sut benchmark.

This is preliminary data for benchmark scores, but should become more full featured in the future.

Intended to supersede --web-only option in run benchmark cli


I am very, very open to any suggestions on the implementation of this. This pass is just to give a minimum viable dev build for iterating on HTML and CSS. I can imagine wanting to put this somewhere else in the code base or even running it differently. So please do share any ideas you might have.

Copy link

github-actions bot commented Feb 29, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

* Add dev build command for local development

This is to allow for a more rapid iteration loop than running a full sut
benchmark.

This is preliminary data for benchmark scores, but should become more
full featured in the future.

Intended to supersede `--web-only` option in run benchmark cli
@wpietri
Copy link
Contributor

wpietri commented Mar 1, 2024

I'm a bit perplexed here. The notion of --web-only was that it would skip the benchmarking step and just use the most recent generated thing. We just couldn't do that with newhelm until they started persisting things to disk. Are you looking for this as a temporary solution to speed things up for you? If so, I'm fine with it. But for the long term, I'd rather use real runs, so there's no duplication between the fake runs and the real, as they'd diverge over time.

@mkly
Copy link
Member Author

mkly commented Mar 1, 2024

Are you looking for this as a temporary solution to speed things up for you?

Indeed. It was expressed by a member of the team that a quick iteration cycle was important. This seemed like a quick way to implement that for template html and css development. While using it, it does speed things up for me compared to what we currently have working.

@mkly mkly merged commit dc8ba65 into main Mar 1, 2024
2 checks passed
@mkly mkly deleted the mkly/dev-build-1 branch March 1, 2024 23:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants