Fix cache bug #779
Merged
Fix cache bug #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Error
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Failure
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Failure
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
rogthefrog
approved these changes
Jan 7, 2025
wpietri
approved these changes
Jan 7, 2025
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the cache collision bug for SUTs in modelbench. I also added some more cache testing.
This is a simple fix-- it just prepends the SUT UID to the cache key. We should discuss if it makes sense for all the SUTs to share one cache or if we would benefit from having one cache per SUT. Same for the annotators.