hack so we can get value out of the test #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prompt files in a more dignified way
rogthefrog
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
rogthefrog
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
rogthefrog
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Open
wpietri
approved these changes
Jan 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until we deal with localized prompt files in a more dignified way.
Currently, the smoke test appears to do the cross product of locale x prompt file to generate test items. This leads to a situation where it tries to collect fr_fr prompts from a file that only contains en_us prompts, and as a result the test fails.
The failure was useful in identifying a logic bug in the locale x prompt file handling, which we already knew needs a good cleanup.
This PR puts in a workaround to skip the fr_fr prompts in the test only. There will be a separate PR to clean up the prompt file handling.