Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pypi test back #787

Merged
merged 13 commits into from
Jan 15, 2025
Merged

Add pypi test back #787

merged 13 commits into from
Jan 15, 2025

Conversation

rogthefrog
Copy link
Contributor

@rogthefrog rogthefrog commented Jan 13, 2025 •
edited
Loading

This properly belongs with modelbench. We should be alerted if a Pypi build is broken.

#790

@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 13, 2025 20:18 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 13, 2025 20:18 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 13, 2025 20:18 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 13, 2025 22:02 — with GitHub Actions Inactive
@rogthefrog
add fake secrets to suppress errors when tests run. This may actually…
80b64fc 
… cause the tests to fail, so let's see if it does what we want.
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 13, 2025 22:09 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 13, 2025 22:14 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 13, 2025 22:32 — with GitHub Actions Inactive
@rogthefrog rogthefrog changed the title add pypi test back Add pypi test back Jan 13, 2025
@rogthefrog rogthefrog marked this pull request as ready for review January 13, 2025 22:44
@rogthefrog rogthefrog requested a review from a team as a code owner January 13, 2025 22:44
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 13, 2025 22:46 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 13, 2025 22:46 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 13, 2025 22:46 — with GitHub Actions Inactive
@rogthefrog rogthefrog mentioned this pull request Jan 13, 2025
Open
wpietri
wpietri approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@wpietri wpietri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. As long as it really needs the secret, I'm fine with it.

@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 15, 2025 21:32 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 15, 2025 21:32 — with GitHub Actions Inactive
@rogthefrog rogthefrog temporarily deployed to Scheduled Testing January 15, 2025 21:32 — with GitHub Actions Inactive
@rogthefrog rogthefrog merged commit 6772b98 into main Jan 15, 2025
4 checks passed
@rogthefrog rogthefrog deleted the fix/move-pypi-test-back branch January 15, 2025 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wpietri wpietri wpietri approved these changes

@dhosterman dhosterman Awaiting requested review from dhosterman

@bkorycki bkorycki Awaiting requested review from bkorycki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rogthefrog @wpietri @bkorycki