Retry decorator #864
Merged
Retry decorator #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Failure
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Error
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Error
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
dhosterman
reviewed
Feb 14, 2025
src/modelgauge/retry_decorator.py
Outdated
| MAX_BACKOFF = 60 # 1 minute in seconds | ||
|
|
||
|
|
||
| def retry(unacceptable_exceptions=None): |
There was a problem hiding this comment.
This naming was very confusing to me on first read. Would it still make sense to use a parameter like exceptions_to_retry or transient_exceptions or something similar?
There was a problem hiding this comment.
I like transient_exceptions! Updated.
wpietri
requested changes
Feb 14, 2025
src/modelgauge/retry_decorator.py
Outdated
| MAX_BACKOFF = 60 # 1 minute in seconds | ||
|
|
||
|
|
||
| def retry(unacceptable_exceptions=None): |
src/modelgauge/retry_decorator.py
Outdated
| try: | ||
| return func(*args, **kwargs) | ||
| except unacceptable_exceptions as e: | ||
| # Keep retrying "unacceptable" exceptions for 1 day. |
There was a problem hiding this comment.
This could definitely use some logging. Basic logging now is configured in run.py:cli. I'd say log anything you think will be interesting in trying to a) figure out what the problem is with a service, and b) verifying that our retry logic is sensible.
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Failure
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Error
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Error
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Failure
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Failure
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Failure
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
wpietri
approved these changes
Feb 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A retry decorator that SUTs can use on their
evaluatemethod. It is designed around the idea that there are two types of exceptions: those that should only retried a handful of times and those that should be more persistently retried until success (e.g. rate limits).