Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup typescript #18

Merged
merged 12 commits into from
Feb 24, 2023
Merged

Setup typescript #18

merged 12 commits into from
Feb 24, 2023

Conversation

EscapedGibbon
Copy link
Contributor

First draft

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 98.37% // Head: 97.52% // Decreases project coverage by -0.86% ⚠️

Coverage data is based on head (c0d3879) compared to base (b719955).
Patch coverage: 98.26% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   98.37%   97.52%   -0.86%     
==========================================
  Files           4        5       +1     
  Lines         185      202      +17     
  Branches       29       31       +2     
==========================================
+ Hits          182      197      +15     
- Misses          3        5       +2     
Impacted Files Coverage Δ
src/kmeans.ts 92.85% <97.05%> (ø)
src/initialization.ts 98.71% <97.22%> (ø)
src/KMeansResult.ts 100.00% <100.00%> (ø)
src/assert.ts 100.00% <100.00%> (ø)
src/utils.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stropitek stropitek marked this pull request as draft January 17, 2023 10:57
src/KMeansResult.ts Outdated Show resolved Hide resolved
src/KMeansResult.ts Outdated Show resolved Hide resolved
EscapedGibbon and others added 3 commits January 20, 2023 09:55
refactor: change the way of typing elements
test: change test output for checking errors
BREAKING CHANGE: kmeans is no longer a default export

BREAKING CHANGE: remove withIterations options and instead export generatorKmeans
@stropitek stropitek marked this pull request as ready for review January 26, 2023 07:47
@stropitek
Copy link
Member

@EscapedGibbon can you ping when you are done working on what we discussed about this PR?

@EscapedGibbon
Copy link
Contributor Author

@stropitek I think I am done with it. The default exports were removed and I think documentation should look better once it is built. But there is a coverage test that doesn't go through.

@stropitek stropitek merged commit 878bf1c into master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants