Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap numpy version to less than 2.0.0 #68

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Cap numpy version to less than 2.0.0 #68

merged 3 commits into from
Aug 8, 2024

Conversation

joeloskarsson
Copy link
Collaborator

@joeloskarsson joeloskarsson commented Aug 8, 2024

Describe your changes

Nerual-lam is at the moment not completely compatible with the new release of numpy 2. This PR changes the numpy version in requirements.txt to < 2.0.0.

Issue Link

#67

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging)

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • author has added an entry to the changelog (and designated the change as added, changed or fixed)
  • Once the PR is ready to be merged, squash commits and merge the PR.

@joeloskarsson joeloskarsson added the bug Something isn't working label Aug 8, 2024
@joeloskarsson joeloskarsson self-assigned this Aug 8, 2024
Copy link
Collaborator

@sadamov sadamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Personally I ran into "Alias np.float_ has been removed. Use np.float64 instead." But there might be more issues we can fix down the road. https://numpy.org/devdocs/release/2.0.0-notes.html

@joeloskarsson joeloskarsson merged commit 72965a9 into main Aug 8, 2024
16 checks passed
@joeloskarsson joeloskarsson deleted the cap_numpy2 branch August 8, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants