Retry all 5xx status codes #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have encountered a site that likes to return 504s. Retries appear to work with them. I'd like to expand the logic in Sickle to handle it.
|
@mloesch Is there any interest in getting this change in? Would love to keep using the main package instead of forking. But if you have objections to how this is implemented, I'd love to try to work towards getting this functionality in. Thanks |
mloesch
added a commit
that referenced
this pull request
May 3, 2020
Additional changes: - retry logic has been fixed: `max_retries` now actully denotes the number of retries, not the number of total attempts - the default waiting time between HTTP retries is now customizable
|
Superseded by #41 |
mloesch
added a commit
that referenced
this pull request
May 4, 2020
Additional changes: - retry logic has been fixed: `max_retries` now actully denotes the number of retries, not the number of total attempts - the default waiting time between HTTP retries is now customizable
|
fix released with 0.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebases existing PR #21 on top of the current master, ensuring that all required Travis tests pass. Since that PR has not seen any movement in a year, I though it might be easier to start clean.
I found the original PR useful, as I have also encountered multiple OAI servers that will return 500 errors instead of the 503 that is indicated in the specification. Expanding retry behavior to more 5xx status codes would be extremely useful for fully automated harvests taking place in a distributed process over a large number of diverse server implementations.
And thanks for working on sickle. It's great.