adding inputs from v1.0.1 to aorsf learner (#299)

* adding inputs from v1.0.1 to aorsf learner * correct tags and include newer params in test
mlr-org · Oct 16, 2023 · 3855302 · 3855302
1 parent 3e43a28
commit 3855302
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/R/learner_aorsf_surv_aorsf.R b/R/learner_aorsf_surv_aorsf.R
@@ -37,11 +37,18 @@ delayedAssign(
           n_tree = p_int(default = 500L, lower = 1L, tags = "train"),
           n_split = p_int(default = 5L, lower = 1L, tags = "train"),
           n_retry = p_int(default = 3L, lower = 0L, tags = "train"),
+          n_thread = p_int(default = 1, lower = 0, tags = c("train", "predict")),
+          pred_aggregate = p_lgl(default = TRUE, tags = "predict"),
           mtry = p_int(default = NULL, lower = 1L,
             special_vals = list(NULL), tags = "train"),
           mtry_ratio = p_dbl(lower = 0, upper = 1, tags = "train"),
+          sample_with_replacement = p_lgl(default = TRUE, tags = "train"),
+          sample_fraction = p_dbl(lower = 0, upper = 1, default = .632,
+            tags = "train"),
           control_type = p_fct(levels = c("fast", "cph", "net"),
             default = "fast", tags = "train"),
+          split_rule = p_fct(levels = c("logrank", "cstat"),
+            default = "logrank", tags = "train"),
           control_fast_do_scale = p_lgl(default = TRUE, tags = "train"),
           control_fast_method = p_fct(levels = c("efron", "breslow"),
             default = "efron", tags = "train"),

diff --git a/tests/testthat/test_paramtest_aorsf_surv_aorsf.R b/tests/testthat/test_paramtest_aorsf_surv_aorsf.R
@@ -38,6 +38,7 @@ test_that("paramtest surv.aorsf predict", {
     "pred_horizon", # all times required for distr
     "pred_type", # handled internally
     "na_action", # not implemented
+    "verbose_progress", # handled internally
     "boundary_checks" # not implemented
   )
   paramtest = run_paramtest(learner, fun_list, exclude, tag = "predict")