Add randomPlantedForest learners (classif, regr) #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Install this branch for a hacky roxygen workaround: https://github.com/mlr-org/mlr3misc/tree/fix/document-leanify |
sebffischer
requested changes
Oct 20, 2023
sebffischer
requested changes
Oct 20, 2023
sebffischer
requested changes
Oct 23, 2023
tests/testthat/test_paramtest_randomPlantedForest_classif_rpf.R
Outdated
Show resolved
Hide resolved
|
Thanks! Okay, I think the only thing left is to figure out what to do about the custom parameters (#304 (comment)). |
sebffischer
requested changes
Oct 27, 2023
sebffischer
requested changes
Nov 2, 2023
| #' The parameter `max_interaction_limit` can optionally be set as an upper bound, such that | ||
| #' `max_interaction_ratio * min(n_features, max_interaction_limit)` is used instead. | ||
| #' This is analogous to `mtry.ratio` in [`classif.ranger`][mlr3learners::mlr_learners_classif.ranger], with | ||
| #' `max_interaction_limit` as an additional constraint. |
There was a problem hiding this comment.
mention that max_interaction_limit is initialized to Inf
Co-authored-by: Sebastian Fischer <sebf.fischer@gmail.com>
Co-authored-by: Sebastian Fischer <sebf.fischer@gmail.com>
Co-authored-by: Sebastian Fischer <sebf.fischer@gmail.com>
Co-authored-by: Sebastian Fischer <sebf.fischer@gmail.com>
Co-authored-by: Sebastian Fischer <sebf.fischer@gmail.com>
sebffischer
reviewed
Nov 2, 2023
| param_set = ps( | ||
| max_interaction = p_int(lower = 0, upper = Inf, default = 1, tags = "train"), | ||
| max_interaction_ratio = p_dbl(lower = 0, upper = 1, tags = "train"), | ||
| max_interaction_limit = p_int(lower = 1, upper = Inf, tags = c("required", "train")), |
There was a problem hiding this comment.
Suggested change
| max_interaction_limit = p_int(lower = 1, upper = Inf, tags = c("required", "train")), | |
| max_interaction_limit = p_int(lower = 1, upper = Inf, tags = c("required", "train"), special_vals = list(Inf)), |
Co-authored-by: Sebastian Fischer <sebf.fischer@gmail.com>
sebffischer
reviewed
Nov 2, 2023
sebffischer
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
randomPlantedForestlearners for classification and regression.I started this fork some time ago to use the learners in a benchmark and it's high time to make it official I guess.
There are still some things to do though:
DESCRIPTION