Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NA as task type #106

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Allow NA as task type #106

merged 1 commit into from
Nov 18, 2021

Conversation

mllg
Copy link
Sponsor Member

@mllg mllg commented Oct 18, 2021

Variance does not require a target, so this should also work with clustering or survival tasks.

@pat-s
Copy link
Member

pat-s commented Oct 19, 2021

Would it be more descriptive to explicitly list survival and cluster tasks instead of allowing NA? How do we handle this in other places in mlr3?

@mllg
Copy link
Sponsor Member Author

mllg commented Nov 16, 2021

It would be possible to extend with surv + clust, but this would not reflect what we really want to say: the task type does not matter here.

I'm also setting the task type to NA in mlr3 if I want to allow any type.

@pat-s pat-s merged commit 4c5d0c6 into main Nov 18, 2021
@pat-s pat-s deleted the task_type_any branch November 18, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants