Support list key_field in Source. #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katyakats
approved these changes
Apr 8, 2021
katyakats
pushed a commit
to katyakats/storey
that referenced
this pull request
Apr 19, 2021
Co-authored-by: Gal Topper <galt@iguazio.com>
katyakats
added a commit
that referenced
this pull request
Apr 22, 2021
* ML-280: adding filter (before and after) to ReadParquet * Support list key_field in Source. (#197) Co-authored-by: Gal Topper <galt@iguazio.com> * Cache (#184) * refactor * working integ * lint * fix typo * test fixes * lint * temp * integ * parametrize tests * rename * handle exceptions inside flush worker * mid * fix reuse * flushing * use changed items list instead of time lookup * check if running loop exists * add test * fix test * add flush interval enum * update test and doc * code review * make flush interval an optional[int] and init_flush_task only from async code * update doc Co-authored-by: Dina Nimrodi <dinan@iguazio.com> * iterate over a copy of changed keys (#198) * iterate over a copy of changed keys * don't add key to persist job if it's already pending * fix several bugs Co-authored-by: Dina Nimrodi <dinan@iguazio.com> * ML-389: Fix expected webapi error in case of concurrent modification of aggregations. (#199) * Don't use now in tests. * ML-389: Fix expected webapi error in case of concurrent modification of aggregations. Co-authored-by: Gal Topper <galt@iguazio.com> * some cleanup * more cleanup * fix * PR comments and adding read_parquet with filtering * some cleanup * filter by column inside the method * pr comment * bug fix * bug fix * bug fix * one more bug fix * pr comments * fix * pr comments * minor fix Co-authored-by: Gal Topper <galt@iguaz.io> Co-authored-by: Gal Topper <galt@iguazio.com> Co-authored-by: Dina Nimrodi <dinaleventol@gmail.com> Co-authored-by: Dina Nimrodi <dinan@iguazio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.