Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML-655: none value should remain None in CsvSource #237

Merged
merged 2 commits into from
Jun 15, 2021
Merged

ML-655: none value should remain None in CsvSource #237

merged 2 commits into from
Jun 15, 2021

Conversation

katyakats
Copy link
Contributor

No description provided.

gtopper
gtopper reviewed Jun 15, 2021
View reviewed changes
tests/test_flow.py Outdated
Comment on lines 2598 to 2599
columns = ['first_name', "str"]
data = pd.DataFrame([['katya', "strrrr"], ['dina', None]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" -> '

gtopper
gtopper reviewed Jun 15, 2021
View reviewed changes
tests/test_flow.py Outdated
u.to_parquet(out_file_par)
r2 = pd.read_parquet(out_file_par)

assert r2["str"].compare(read_back_df["str"]).empty
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" -> '

@katyakats katyakats merged commit c6179ac into mlrun:development Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtopper gtopper gtopper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katyakats @gtopper